remote ray client example #833
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #833 +/- ##
=======================================
Coverage 92.45% 92.45%
=======================================
Files 24 24
Lines 1419 1419
=======================================
Hits 1312 1312
Misses 107 107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
openshift-ci
bot
added
lgtm
laurafitzgerald
force-pushed
the
remote-client-example
branch
2 times, most recently
from
a89a19e to
7a38136
Compare
| "# Setup Authentication Configuration \n", | ||
| "\n", | ||
| "header = {\n", | ||
| " 'Authorization': f'Bearer {\"<auth-token>\"}'\n", |
There was a problem hiding this comment.
Maybe something like this would be clearer:
auth_token = "XXXX" # Your OpenShift authentication token
header = {
'Authorization': f'Bearer {auth_token}'
}
There was a problem hiding this comment.
Have a check in that recent push sir!
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "# Submit an a job using the RayJobClient\n", |
There was a problem hiding this comment.
# Submit a job using the RayJobClient
| "# Import pieces from codeflare-sdk\n", | ||
| "from codeflare_sdk import Cluster, ClusterConfiguration, TokenAuthentication, RayJobClient\n", | ||
| "\n", | ||
| "# Gather the dashboard URL\n", |
There was a problem hiding this comment.
For the sake of clarity might we say:
# Gather the dashboard URL (provided by the RayCluster creator)
chipspeak
force-pushed
the
remote-client-example
branch
from
7a38136 to
66333e8
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kryanbeane The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
removed
the
approved
chipspeak
force-pushed
the
remote-client-example
branch
2 times, most recently
from
e2dce47 to
ed39723
Compare
Co-authored-by: bkeane <[email protected]> Co-authored-by: chipspeak <[email protected]> Co-authored-by: Bobbins <[email protected]>
chipspeak
force-pushed
the
remote-client-example
branch
from
ed39723 to
77e810a
Compare
No description provided.